Split Actor logs in their own files #495
Open
+135
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
f0385b1 to
048a940
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78101221 |
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
048a940 to
c0fb40b
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 11, 2025
Summary: - Each actor type will create a new file suffixed with the actor name - Each log will contain the proc and rank id of the actor. This will simplify filtering to logs of a single actor - Logs not coming from an actor will be dumped in a common file suffixed 'monarch' - Additionally stream all logs to stdout when `MONARCH_STDOUT=1` TODO: - Support Python Actors Differential Revision: D78101221
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 11, 2025
Summary: - Each actor type will create a new file suffixed with the actor name - Each log will contain the proc and rank id of the actor. This will simplify filtering to logs of a single actor - Logs not coming from an actor will be dumped in a common file suffixed 'monarch' - Additionally stream all logs to stdout when `MONARCH_STDOUT=1` TODO: - Support Python Actors Differential Revision: D78101221
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
c0fb40b to
056f3b3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78101221 |
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
056f3b3 to
c93f3e1
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 11, 2025
Summary: Pull Request resolved: pytorch-labs#495 - Each actor type will create a new file suffixed with the actor name - Each log will contain the proc and rank id of the actor. This will simplify filtering to logs of a single actor - Logs not coming from an actor will be dumped in a common file suffixed 'monarch' - Additionally stream all logs to stdout when `MONARCH_STDOUT=1` TODO: - Support Python Actors Differential Revision: D78101221
|
This pull request was exported from Phabricator. Differential Revision: D78101221 |
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 11, 2025
Summary: Pull Request resolved: pytorch-labs#495 - Each actor type will create a new file suffixed with the actor name - Each log will contain the proc and rank id of the actor. This will simplify filtering to logs of a single actor - Logs not coming from an actor will be dumped in a common file suffixed 'monarch' - Additionally stream all logs to stdout when `MONARCH_STDOUT=1` TODO: - Support Python Actors Differential Revision: D78101221
pablorfb-meta
force-pushed
the
export-D78101221
branch
2 times, most recently
from
fdd3ad3 to
8d942e7
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 13, 2025
Summary: - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 13, 2025
Summary: - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
8d942e7 to
7de464f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78101221 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78101221 |
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 13, 2025
Summary: - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
7de464f to
799c6a7
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 13, 2025
Summary: - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
799c6a7 to
d44efbe
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 13, 2025
Summary: - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
d44efbe to
d54eec7
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 13, 2025
Summary: - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
d54eec7 to
48f4e49
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78101221 |
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 13, 2025
Summary: Pull Request resolved: pytorch-labs#495 - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
48f4e49 to
368d0d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78101221 |
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
368d0d5 to
0876339
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 13, 2025
Summary: Pull Request resolved: pytorch-labs#495 - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
0876339 to
bcfd687
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Jul 13, 2025
Summary: Pull Request resolved: pytorch-labs#495 - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
|
This pull request was exported from Phabricator. Differential Revision: D78101221 |
Summary: Pull Request resolved: pytorch-labs#495 - Add per proc suffix to file logger - Gate STDERR logging with flag Differential Revision: D78101221
|
This pull request was exported from Phabricator. Differential Revision: D78101221 |
pablorfb-meta
force-pushed
the
export-D78101221
branch
from
bcfd687 to
2b78ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TODO:
Differential Revision: D78101221